[libc-commits] [libc] [libc] fix lfind entrypoints (PR #115771)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Mon Nov 11 13:33:12 PST 2024


https://github.com/nickdesaulniers created https://github.com/llvm/llvm-project/pull/115771

- move arm entrypoint to fullbuild only
- remove baremetal entrypoints; we avoid POSIX on baremetal
- remove darwin/arm and windows entrypoints since these are untested

Fixes: #114692


>From 0d7eae6433af4f2a5ea610dba94487bcd3786121 Mon Sep 17 00:00:00 2001
From: Nick Desaulniers <ndesaulniers at google.com>
Date: Mon, 11 Nov 2024 13:31:42 -0800
Subject: [PATCH] [libc] fix lfind entrypoints

- move arm entrypoint to fullbuild only
- remove baremetal entrypoints; we avoid POSIX on baremetal
- remove darwin/arm and windows entrypoints since these are untested

Fixes: #114692
---
 libc/config/baremetal/arm/entrypoints.txt   | 3 ---
 libc/config/baremetal/riscv/entrypoints.txt | 3 ---
 libc/config/darwin/arm/entrypoints.txt      | 3 ---
 libc/config/linux/arm/entrypoints.txt       | 6 +++---
 libc/config/windows/entrypoints.txt         | 3 ---
 5 files changed, 3 insertions(+), 15 deletions(-)

diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt
index f59208deba614c..b85ae1119345dd 100644
--- a/libc/config/baremetal/arm/entrypoints.txt
+++ b/libc/config/baremetal/arm/entrypoints.txt
@@ -26,9 +26,6 @@ set(TARGET_LIBC_ENTRYPOINTS
     # errno.h entrypoints
     libc.src.errno.errno
 
-    # search.h entrypoints
-    libc.src.search.lfind
-
     # setjmp.h entrypoints
     libc.src.setjmp.longjmp
     libc.src.setjmp.setjmp
diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt
index e59c4e843e5d5c..199a030ee6371e 100644
--- a/libc/config/baremetal/riscv/entrypoints.txt
+++ b/libc/config/baremetal/riscv/entrypoints.txt
@@ -26,9 +26,6 @@ set(TARGET_LIBC_ENTRYPOINTS
     # errno.h entrypoints
     libc.src.errno.errno
 
-    # search.h entrypoints
-    libc.src.search.lfind
-
     # string.h entrypoints
     libc.src.string.bcmp
     libc.src.string.bcopy
diff --git a/libc/config/darwin/arm/entrypoints.txt b/libc/config/darwin/arm/entrypoints.txt
index 13860015ae5841..2d5dbeff485747 100644
--- a/libc/config/darwin/arm/entrypoints.txt
+++ b/libc/config/darwin/arm/entrypoints.txt
@@ -20,9 +20,6 @@ set(TARGET_LIBC_ENTRYPOINTS
     # errno.h entrypoints
     libc.src.errno.errno
 
-    # search.h entrypoints
-    libc.src.search.lfind 
-
     # string.h entrypoints
     libc.src.string.bcmp
     libc.src.string.bcopy
diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt
index b4f08cde6df48a..31d81de06fb6b0 100644
--- a/libc/config/linux/arm/entrypoints.txt
+++ b/libc/config/linux/arm/entrypoints.txt
@@ -20,9 +20,6 @@ set(TARGET_LIBC_ENTRYPOINTS
     # errno.h entrypoints
     libc.src.errno.errno
 
-    # search.h entrypoints
-    libc.src.search.lfind  
-
     # string.h entrypoints
     libc.src.string.bcmp
     libc.src.string.bcopy
@@ -186,6 +183,9 @@ set(TARGET_LIBC_ENTRYPOINTS
 
 if(LLVM_LIBC_FULL_BUILD)
   list(APPEND TARGET_LIBC_ENTRYPOINTS
+    # search.h entrypoints
+    libc.src.search.lfind
+
     # setjmp.h entrypoints
     libc.src.setjmp.longjmp
     libc.src.setjmp.setjmp
diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt
index 5ffd32373148cd..8f0b50bcc83ea2 100644
--- a/libc/config/windows/entrypoints.txt
+++ b/libc/config/windows/entrypoints.txt
@@ -17,9 +17,6 @@ set(TARGET_LIBC_ENTRYPOINTS
     libc.src.ctype.tolower
     libc.src.ctype.toupper
 
-    # search.h entrypoints
-    libc.src.search.lfind
-
     # string.h entrypoints
     libc.src.string.bcmp
     libc.src.string.bcopy



More information about the libc-commits mailing list