[libc-commits] [libc] [libc] Fix all imports of src/string/memory_utils (PR #114939)
Nick Desaulniers via libc-commits
libc-commits at lists.llvm.org
Mon Nov 11 09:29:56 PST 2024
================
@@ -54,11 +54,9 @@ add_header_library(
add_header_library(
common
HDRS
- common.h
- endian.h
----------------
nickdesaulniers wrote:
I don't think it's correct to remove common.h and endian.h from the "common" header library.
For example, `endian_test` (libc/test/src/__support/CMakeLists.txt) depends on libc.src.__support.common. If you remove endian.h from `common`, then you need to add it back explicitly for that test (and anywhere else that was implicitly depending on endian.h from `common`.
It's ok to split endian.h off from `common`, but I'd do that in a separate PR and keep this PR more focused.
https://github.com/llvm/llvm-project/pull/114939
More information about the libc-commits
mailing list