[libc-commits] [libc] [libc] Add the `src/stdlib/_Exit.h` header to `at_quick_exit_test.cpp` and `atexit_test.cpp` (PR #115351)
Job Henandez Lara via libc-commits
libc-commits at lists.llvm.org
Thu Nov 7 09:49:39 PST 2024
https://github.com/Jobhdez created https://github.com/llvm/llvm-project/pull/115351
Hello, I merged this https://github.com/llvm/llvm-project/pull/114904 a few mins ago and the tests failed because i did not add the header `src/stdlib/_Exit.h` in `at_quick_exit_test.cpp` and `atexit_test.cpp`.
I ran both builds/tests and everything was good. thanks
>From 6300a14b933c7c58ec7d97e54a3d9fa8f1326f8f Mon Sep 17 00:00:00 2001
From: Job Hernandez <jobhdezlara93 at gmail.com>
Date: Thu, 7 Nov 2024 09:44:25 -0800
Subject: [PATCH 1/2] add include for _Exit
---
libc/test/src/stdlib/at_quick_exit_test.cpp | 1 +
libc/test/src/stdlib/atexit_test.cpp | 1 +
2 files changed, 2 insertions(+)
diff --git a/libc/test/src/stdlib/at_quick_exit_test.cpp b/libc/test/src/stdlib/at_quick_exit_test.cpp
index 1ed5a83a61b8d0..efc8529629f125 100644
--- a/libc/test/src/stdlib/at_quick_exit_test.cpp
+++ b/libc/test/src/stdlib/at_quick_exit_test.cpp
@@ -9,6 +9,7 @@
#include "src/__support/CPP/array.h"
#include "src/__support/CPP/utility.h"
#include "src/stdlib/at_quick_exit.h"
+#include "src/stdlib/_Exit.h"
#include "src/stdlib/quick_exit.h"
#include "test/UnitTest/Test.h"
diff --git a/libc/test/src/stdlib/atexit_test.cpp b/libc/test/src/stdlib/atexit_test.cpp
index 24f8b0451f3636..609999a259bfab 100644
--- a/libc/test/src/stdlib/atexit_test.cpp
+++ b/libc/test/src/stdlib/atexit_test.cpp
@@ -9,6 +9,7 @@
#include "src/__support/CPP/array.h"
#include "src/__support/CPP/utility.h"
#include "src/stdlib/atexit.h"
+#include "src/stdlib/_Exit.h"
#include "src/stdlib/exit.h"
#include "test/UnitTest/Test.h"
>From 27557104e81be71c3857e45fad728eca27405244 Mon Sep 17 00:00:00 2001
From: Job Hernandez <jobhdezlara93 at gmail.com>
Date: Thu, 7 Nov 2024 09:44:56 -0800
Subject: [PATCH 2/2] format code
---
libc/test/src/stdlib/at_quick_exit_test.cpp | 2 +-
libc/test/src/stdlib/atexit_test.cpp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libc/test/src/stdlib/at_quick_exit_test.cpp b/libc/test/src/stdlib/at_quick_exit_test.cpp
index efc8529629f125..c0aac4d20d92cc 100644
--- a/libc/test/src/stdlib/at_quick_exit_test.cpp
+++ b/libc/test/src/stdlib/at_quick_exit_test.cpp
@@ -8,8 +8,8 @@
#include "src/__support/CPP/array.h"
#include "src/__support/CPP/utility.h"
-#include "src/stdlib/at_quick_exit.h"
#include "src/stdlib/_Exit.h"
+#include "src/stdlib/at_quick_exit.h"
#include "src/stdlib/quick_exit.h"
#include "test/UnitTest/Test.h"
diff --git a/libc/test/src/stdlib/atexit_test.cpp b/libc/test/src/stdlib/atexit_test.cpp
index 609999a259bfab..c25202ff54f696 100644
--- a/libc/test/src/stdlib/atexit_test.cpp
+++ b/libc/test/src/stdlib/atexit_test.cpp
@@ -8,8 +8,8 @@
#include "src/__support/CPP/array.h"
#include "src/__support/CPP/utility.h"
-#include "src/stdlib/atexit.h"
#include "src/stdlib/_Exit.h"
+#include "src/stdlib/atexit.h"
#include "src/stdlib/exit.h"
#include "test/UnitTest/Test.h"
More information about the libc-commits
mailing list