[libc-commits] [libc] [libc][i386] FPBit support for 96b long double (PR #115084)

via libc-commits libc-commits at lists.llvm.org
Wed Nov 6 10:49:01 PST 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 5e75f294f1e2900e75f1f1e2cc4e5abe46366047 474aad73d1213340663ceb631ba2c78ef774b9ca --extensions cpp,h -- libc/src/__support/FPUtil/FPBits.h libc/src/__support/FPUtil/generic/sqrt_80_bit_long_double.h libc/src/__support/big_int.h libc/src/__support/float_to_string.h libc/src/__support/integer_literals.h libc/src/__support/str_to_float.h libc/test/UnitTest/LibcTest.cpp libc/test/src/__support/FPUtil/fpbits_test.cpp libc/test/src/__support/big_int_test.cpp libc/test/src/__support/str_to_long_double_test.cpp libc/test/src/stdlib/strtold_test.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libc/src/__support/FPUtil/FPBits.h b/libc/src/__support/FPUtil/FPBits.h
index 2b030b51c3..dcf91c277c 100644
--- a/libc/src/__support/FPUtil/FPBits.h
+++ b/libc/src/__support/FPUtil/FPBits.h
@@ -134,9 +134,9 @@ template <> struct FPLayout<FPType::X86_Binary80> {
 #elif __SIZEOF_LONG_DOUBLE__ == 12
   using StorageType = UInt<__SIZEOF_LONG_DOUBLE__ * CHAR_BIT>;
 #else
-# TODO: https://github.com/llvm/llvm-project/issues/115184
-# Android i386 uses `long double == double` i.e. `sizeof(long double) == 8`
-# https://developer.android.com/ndk/guides/abis#x86
+#TODO : https: // github.com/llvm/llvm-project/issues/115184
+#Android i386 uses `long double == double` i.e. `sizeof(long double) == 8`
+#https: // developer.android.com/ndk/guides/abis#x86
 #error "unexpected size of long double"
 #endif
   LIBC_INLINE_VAR static constexpr int SIGN_LEN = 1;

``````````

</details>


https://github.com/llvm/llvm-project/pull/115084


More information about the libc-commits mailing list