[libc-commits] [libc] [libc][search] implement posix `lfind` function (PR #114692)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Mon Nov 4 09:44:05 PST 2024


================
@@ -0,0 +1,46 @@
+//===-- Unittests for lfind -----------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/search/lfind.h"
+#include "test/UnitTest/Test.h"
+
+int compar(void *a, void *b) {
+  return *reinterpret_cast<int *>(a) - *reinterpret_cast<int *>(b);
----------------
nickdesaulniers wrote:

This could also be:
```suggestion
  return *reinterpret_cast<int *>(a) == *reinterpret_cast<int *>(b);
```
which I think is more straightforward for what the compare function is doing.

https://github.com/llvm/llvm-project/pull/114692


More information about the libc-commits mailing list