[libc-commits] [libc] [libc] NVPTX Profiling Draft (PR #92009)

[Joseph Huber via libc-commits]

jhuber6 wrote:

> I'm pretty sure the CI fail is caused by my wrong implementation of iterators. Would you be able to review the iterator implementation for anything that seems blatantly wrong? I was a little confused by the implementation of the `reverse_iterator` and can't seem to get the `begin()` and `end()` function calls correct

Can you make the iterators a separate patch? In any case, the iterators should be present in the `cpp::Array` class, which is pretty much just `Ptr` and `Ptr + Size` for the return values of begin, end respectively. Refer to https://en.cppreference.com/w/cpp/language/range-for for what this requires a class to implement to work.

Also might be worth rebasing your branch on main.

https://github.com/llvm/llvm-project/pull/92009