amykhuang wrote: super nit: for the commit message I'd summarize the change first (a line, or a paragraph, or whatever) and then you can add the bullet points below. Also they're usually written in present tense for some reason. https://github.com/llvm/llvm-project/pull/93620