[libc-commits] [libc] [libc][POSIX][pthreads] implemented missing pthread_rwlockattr functions (PR #93245)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Thu May 23 15:05:53 PDT 2024


nickdesaulniers wrote:

Thanks for fixing this up! I think it would be easier for reviewers to validate your edition if you:
1. close this pr
2. create a new branch off main
3. `git revert 27595c4befbbf42891ef7e13fe28926eb7fc825d`
4. add the missing piece from the original PR as a distinct commit on top. Keep it separate from the commit in 3.
5. push those 2 commits to a new branch
6. open a PR with 5.

Then we can squash+merge once reviewed.  Do you mind reforming this PR that way?

(I think you could also force push to this branch if you're comfortable doing that, otherwise a new PR is fine).

Thanks for the patch!

https://github.com/llvm/llvm-project/pull/93245


More information about the libc-commits mailing list