[libc-commits] [libc] [llvm] [llvm] Add KnownBits implementations for avgFloor and avgCeil (PR #86445)

Nhat Nguyen via libc-commits libc-commits at lists.llvm.org
Sun May 19 06:50:13 PDT 2024


changkhothuychung wrote:

> > > > looks like the BinaryExhaustive test fails when I remove the bool flag to enable Optimal check?
> > > 
> > > 
> > > Oh, I thought this implementation was supposed to be optimal, but maybe I got that wrong.
> > > Patch LGTM anyway.
> > 
> > 
> > I am assuming I need to put back the flag to disable optimality check ?
> 
> You already do. Its the `bool` argument.

I made a push to put it back after I made that comment. 

https://github.com/llvm/llvm-project/pull/86445


More information about the libc-commits mailing list