[libc-commits] [libc] [llvm] [llvm] Add KnownBits implementations for avgFloor and avgCeil (PR #86445)

Jay Foad via libc-commits libc-commits at lists.llvm.org
Sun May 19 00:31:36 PDT 2024


jayfoad wrote:

> > > looks like the BinaryExhaustive test fails when I remove the bool flag to enable Optimal check?
> > 
> > Oh, I thought this implementation was supposed to be optimal, but maybe I got that wrong.
> > 
> > Patch LGTM anyway.
> 
> I am assuming I need to put back the flag to disable optimality check ? 

Yes (at least for the signed functions CeilS and FloorS) because you can't commit with failing tests.

https://github.com/llvm/llvm-project/pull/86445


More information about the libc-commits mailing list