SchrodingerZhu wrote: > some comments, but overall looks good. I would like to get a chance to review and approve one last time before this lands thought Sure! https://github.com/llvm/llvm-project/pull/92168