[libc-commits] [libc] [libc][errno] Remove errno numbers (PR #92163)

via libc-commits libc-commits at lists.llvm.org
Tue May 14 13:23:27 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libc

Author: Robin Caloudis (robincaloudis)

<details>
<summary>Changes</summary>

Introduced in https://github.com/llvm/llvm-project/pull/91150. Not needed anymore as https://github.com/llvm/llvm-project/pull/92041 fixed the root cause. `ENAMETOOLONG` and `EOVERFLOW` are well defined in `<linux/errno.h>`.

Post mortem: Due to the previously missing inclusion of `<linux/errno.h>` (fixed with https://github.com/llvm/llvm-project/pull/92041), I misinterpreted an undefined macro issue during the development of https://github.com/llvm/llvm-project/pull/91150 as being caused by a missing definition rather than by the missing inclusion of the linux header. I realized too late that `ENAMETOOLONG` and `EOVERFLOW` were correctly defined in `<linux/errno.h>` and that it was my missing inclusion that caused the problem.

---
Full diff: https://github.com/llvm/llvm-project/pull/92163.diff


1 Files Affected:

- (modified) libc/include/llvm-libc-macros/generic-error-number-macros.h (-2) 


``````````diff
diff --git a/libc/include/llvm-libc-macros/generic-error-number-macros.h b/libc/include/llvm-libc-macros/generic-error-number-macros.h
index b5b1b676dacc3..7ee0352669b8a 100644
--- a/libc/include/llvm-libc-macros/generic-error-number-macros.h
+++ b/libc/include/llvm-libc-macros/generic-error-number-macros.h
@@ -44,7 +44,5 @@
 #define EDOM 33
 #define ERANGE 34
 #define EILSEQ 35
-#define ENAMETOOLONG 36
-#define EOVERFLOW 75
 
 #endif // LLVM_LIBC_MACROS_GENERIC_ERROR_NUMBER_MACROS_H

``````````

</details>


https://github.com/llvm/llvm-project/pull/92163


More information about the libc-commits mailing list