[libc-commits] [libc] [libc][math][c23] Fix impl and tests for X86_80 canonicalize function. (PR #87097)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Fri Mar 29 11:17:22 PDT 2024


nickdesaulniers wrote:

Here's how I would fix this up locally; the "git-fu" can be tricky.

```
$ cd llvm-project/
$ git checkout main
$ git pull
$ git checkout -b X86_80
$ git revert d357324f7700188c9ef179a4bc7898079cf49b6f
$ git cherry-pick 1237900e44643b34833b05403ccef2eeee5f6234
$ git cherry-pick 5c30985389d7eac3f334554feb4a4bf3c34824c5
$ git cherry-pick 6ed0c6fa7bdcd4bfc7b7c2cee7dc7bf9e9cde138
$ gh pr create
```
That way in one PR (which can be squashed when merged) we have the revert followed by the fixes. This makes it crystal clear to reviewers that the initial commit is just the inverse of the previous revert, and that the subsequent changes are the fixes. Reviewers can look at the individual commits in github code review.

https://github.com/llvm/llvm-project/pull/87097


More information about the libc-commits mailing list