[libc-commits] [libc] [openmp] [libc] Change RPC interface to not use device ids (PR #87087)

Shilei Tian via libc-commits libc-commits at lists.llvm.org
Fri Mar 29 10:17:46 PDT 2024


================
@@ -1492,7 +1492,7 @@ Error GenericPluginTy::init() {
   GlobalHandler = createGlobalHandler();
   assert(GlobalHandler && "Invalid global handler");
 
-  RPCServer = new RPCServerTy(NumDevices);
+  RPCServer = new RPCServerTy();
   assert(RPCServer && "Invalid RPC server");
----------------
shiltian wrote:

It's not safe to use `assert` for runtime check since in release mode this is simply gone. Potentially if the pointer is null, return failure.

https://github.com/llvm/llvm-project/pull/87087


More information about the libc-commits mailing list