[libc-commits] [libc] [libc][math][c23] Fix X86_Binary80 special cases for canonicalize functions. (PR #86924)

via libc-commits libc-commits at lists.llvm.org
Thu Mar 28 11:55:12 PDT 2024


================
@@ -135,44 +135,38 @@ class CanonicalizeTest : public LIBC_NAMESPACE::testing::Test {
 
       // Exponent   |       Significand      | Meaning
       //            |   Bit 63   | Bits 62-0 |
-      // All Other  |   Zero     | Anything  | Unnormal, Value =
-      //  Values    |            |           | (−1)**s × m × 2**−16382
+      // All Other  |   Zero     | Anything  | Unnormal, Value = SNaN
+      //  Values    |            |           |
 
-      FPBits test5_1(UInt128(0x0000000000000001));
----------------
lntue wrote:

Sorry I just remember that we do have `_u128` literal for testing: https://github.com/llvm/llvm-project/blob/main/libc/test/src/__support/str_to_long_double_test.cpp#L24

Do you mind updating this test file to use it?  They will need to depend on `libc.src.__support.integer_literals` target.

Thanks,

https://github.com/llvm/llvm-project/pull/86924


More information about the libc-commits mailing list