[libc-commits] [libc] [libc] Mark baremetal write_to_stderr as inline (PR #86890)

Petr Hosek via libc-commits libc-commits at lists.llvm.org
Wed Mar 27 16:31:43 PDT 2024


https://github.com/petrhosek updated https://github.com/llvm/llvm-project/pull/86890

>From 0b277d645abd03ff8fbcf81c95947183bf83fb9f Mon Sep 17 00:00:00 2001
From: Petr Hosek <phosek at google.com>
Date: Wed, 27 Mar 2024 16:24:37 -0700
Subject: [PATCH 1/2] [libc] Mark baremetal write_to_stderr as inline

This is required to avoid multiple definitions error.
---
 libc/src/__support/OSUtil/baremetal/io.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libc/src/__support/OSUtil/baremetal/io.h b/libc/src/__support/OSUtil/baremetal/io.h
index a50c11d4aea123..baf4d49cabbc0e 100644
--- a/libc/src/__support/OSUtil/baremetal/io.h
+++ b/libc/src/__support/OSUtil/baremetal/io.h
@@ -16,7 +16,7 @@ namespace LIBC_NAMESPACE {
 // This is intended to be provided by the vendor.
 extern "C" void __llvm_libc_log_write(const char *msg, size_t len);
 
-void write_to_stderr(cpp::string_view msg) {
+inline void write_to_stderr(cpp::string_view msg) {
   __llvm_libc_log_write(msg.data(), msg.size());
 }
 

>From ea7bd3557de68f16e50cdc6572600c1a122e7420 Mon Sep 17 00:00:00 2001
From: Petr Hosek <phosek at google.com>
Date: Wed, 27 Mar 2024 16:31:28 -0700
Subject: [PATCH 2/2] Use LIBC_INLINE

---
 libc/src/__support/OSUtil/baremetal/io.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libc/src/__support/OSUtil/baremetal/io.h b/libc/src/__support/OSUtil/baremetal/io.h
index baf4d49cabbc0e..959b31bb3adb4f 100644
--- a/libc/src/__support/OSUtil/baremetal/io.h
+++ b/libc/src/__support/OSUtil/baremetal/io.h
@@ -16,7 +16,7 @@ namespace LIBC_NAMESPACE {
 // This is intended to be provided by the vendor.
 extern "C" void __llvm_libc_log_write(const char *msg, size_t len);
 
-inline void write_to_stderr(cpp::string_view msg) {
+LIBC_INLINE void write_to_stderr(cpp::string_view msg) {
   __llvm_libc_log_write(msg.data(), msg.size());
 }
 



More information about the libc-commits mailing list