[libc-commits] [libc] [libc] implement ioctl (PR #85890)

[Nick Desaulniers via libc-commits]

================
@@ -0,0 +1,20 @@
+//===-- Implementation header for mmap function -----------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC_SYS_IOCTL_IOCTL_H
+#define LLVM_LIBC_SRC_SYS_IOCTL_IOCTL_H
+
+#include <sys/mman.h> // For size_t and off_t
----------------
nickdesaulniers wrote:

That said, `size_t` and `off_t` do not appear in the signature of this function, so this include is not necessary in this header.

In general we prefer direct includes rather than transitive includes.

Please remove this include line here.

https://github.com/llvm/llvm-project/pull/85890