[libc-commits] [libc] [libc][FPUtil] fixup missing explicit cast (PR #86736)
via libc-commits
libc-commits at lists.llvm.org
Tue Mar 26 13:44:39 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libc
Author: Nick Desaulniers (nickdesaulniers)
<details>
<summary>Changes</summary>
The arm32 buildbot reports an error because UInt::operator bool() is explicit,
thus an explicit cast is necessary.
Link: #<!-- -->85940
---
Full diff: https://github.com/llvm/llvm-project/pull/86736.diff
1 Files Affected:
- (modified) libc/src/__support/FPUtil/BasicOperations.h (+1-1)
``````````diff
diff --git a/libc/src/__support/FPUtil/BasicOperations.h b/libc/src/__support/FPUtil/BasicOperations.h
index 405755f8b57d9b..f746d7ac6ad41f 100644
--- a/libc/src/__support/FPUtil/BasicOperations.h
+++ b/libc/src/__support/FPUtil/BasicOperations.h
@@ -199,7 +199,7 @@ LIBC_INLINE int canonicalize(T &cx, const T &x) {
// Values | | | (−1)**s × m × 2**−16382
bool bit63 = sx.get_implicit_bit();
UInt128 mantissa = sx.get_explicit_mantissa();
- bool bit62 = ((mantissa & (1ULL << 62)) >> 62);
+ bool bit62 = static_cast<bool>((mantissa & (1ULL << 62)) >> 62);
int exponent = sx.get_biased_exponent();
if (exponent == 0x7FFF) {
if (!bit63 && !bit62) {
``````````
</details>
https://github.com/llvm/llvm-project/pull/86736
More information about the libc-commits
mailing list