[libc-commits] [libc] [libc][math] Implement atan2f correctly rounded to all rounding modes. (PR #86716)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Tue Mar 26 13:08:22 PDT 2024


https://github.com/nickdesaulniers approved this pull request.

Once a function starts pushing 100+ lines, consider if it makes sense to start breaking up portions into smaller static functions.  Usually having another block of local variables declared in the middle of the function is a sign that a function can be made more modular.  This has the added benefit of reducing the lifetime of variables which results in reduced stack usage due to improvements in stack slot reuse.

https://github.com/llvm/llvm-project/pull/86716


More information about the libc-commits mailing list