[libc-commits] [libc] [libc] Remove definition of LIBC_NAMESPACE in test (PR #86704)

Michael Jones via libc-commits libc-commits at lists.llvm.org
Tue Mar 26 10:55:08 PDT 2024


https://github.com/michaelrj-google created https://github.com/llvm/llvm-project/pull/86704

The canonicalize test added in #85940 defined the LIBC_NAMESPACE macro.
this macro is intended to be set only by the build system and never in
the code.


>From 4cb6257313b1e1ffa2aacfd10e2e9653baa78cc6 Mon Sep 17 00:00:00 2001
From: Michael Jones <michaelrj at google.com>
Date: Tue, 26 Mar 2024 10:51:40 -0700
Subject: [PATCH] [libc] Remove definition of LIBC_NAMESPACE in test

The canonicalize test added in #85940 defined the LIBC_NAMESPACE macro.
this macro is intended to be set only by the build system and never in
the code.
---
 libc/test/src/math/smoke/CanonicalizeTest.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libc/test/src/math/smoke/CanonicalizeTest.h b/libc/test/src/math/smoke/CanonicalizeTest.h
index ce855d5168565e..c8af83f1983881 100644
--- a/libc/test/src/math/smoke/CanonicalizeTest.h
+++ b/libc/test/src/math/smoke/CanonicalizeTest.h
@@ -22,8 +22,6 @@
 
 #define TEST_REGULAR(x, y, expected) TEST_SPECIAL(x, y, expected, 0)
 
-#define LIBC_NAMESPACE __llvm_libc_19_0_0_git
-
 template <typename T>
 class CanonicalizeTest : public LIBC_NAMESPACE::testing::Test {
 



More information about the libc-commits mailing list