[libc-commits] [libc] [libc][math][c23] Implement canonicalize functions (PR #85940)

via libc-commits libc-commits at lists.llvm.org
Mon Mar 25 12:47:03 PDT 2024


================
@@ -9,10 +9,13 @@
 #ifndef LLVM_LIBC_SRC___SUPPORT_FPUTIL_BASICOPERATIONS_H
 #define LLVM_LIBC_SRC___SUPPORT_FPUTIL_BASICOPERATIONS_H
 
+#include "FEnvImpl.h"
 #include "FPBits.h"
 
 #include "src/__support/CPP/type_traits.h"
+#include "src/__support/UInt128.h"
 #include "src/__support/common.h"
+#include "src/__support/macros/optimization.h" // LIBC_UNLIKELY
----------------
lntue wrote:

Thanks for fixing all the issues!  Everything is built and tested fine on my machine now.

One last thing, do you mind adding:
```
        ":__support_fputil_fenv_impl",
        ":__support_macros_optimization",
        ":__support_uint128",
```
to the dependency of `__support_fputil_basic_operations` in the project's bazel overlay at:
https://github.com/llvm/llvm-project/blob/main/utils/bazel/llvm-project-overlay/libc/BUILD.bazel#L624

and sync to head to resolve the merge conflicts.  After that the patch should be ready to be merged.

Thanks,

https://github.com/llvm/llvm-project/pull/85940


More information about the libc-commits mailing list