[libc-commits] [libc] [llvm] [libc][math][c23] Add {, u}fromfp{, x}{, f, l, f128} functions (PR #86003)

[via libc-commits]

================
@@ -839,6 +839,198 @@ add_fp_unittest(
     libc.src.math.frexpf128
 )
 
+add_fp_unittest(
+  fromfp_test
+  SUITE
+    libc-math-smoke-tests
+  SRCS
+    fromfp_test.cpp
+  HDRS
+    FromfpTest.h
+  DEPENDS
+    libc.src.math.fromfp
----------------
lntue wrote:

Yes, but _include-what-you-use_ is always better, instead of completely relying on transitive dependence.  So if your test directly calls something in those targets, it's always better to directly include them in our DEPENDS list.

https://github.com/llvm/llvm-project/pull/86003