[libc-commits] [libc] [libc][math][c23] add c23 floating point fmaximum and fminimum functions. (PR #86016)

Job Henandez Lara via libc-commits libc-commits at lists.llvm.org
Thu Mar 21 12:50:05 PDT 2024


Jobhdez wrote:

> > > Thanks for the patch! Try `git clang-format HEAD~` to appease the linter!
> > 
> > 
> > I just did that and the checks failed again.
> 
> So what's happening is that the comment on the first line of a few files (see [report](https://github.com/llvm/llvm-project/actions/runs/8366631364/job/22907259985)) is too long. When you run the automated formatter, it's wrapping the line (and appears to do so in a way that doesn't reach a fixed point if the formatter is rerun).
> 
> Rather than commit changes suggested by the formatter where it's wrapping the first line comment, you should reject those changes (or not commit them; `git commit -p` will bring up an interactive mode where you accept/reject individual hunks of a diff) or just fix them directly to be 80 columns.

Thanks. Once I fix the comment do I just run `git clang-format HEAD~`? I have made two commits already. This command will format my first commit right with all the files?

https://github.com/llvm/llvm-project/pull/86016


More information about the libc-commits mailing list