michaelrj-google wrote: Given how simple they should be from this base I would say implementing them in this PR is fine, but if you want to leave them for a followup patch that's also fine. https://github.com/llvm/llvm-project/pull/85438