[libc-commits] [libc] [libc] Add `shm_open/shm_unlink` (PR #84974)

[Nick Desaulniers via libc-commits]

================
@@ -0,0 +1,25 @@
+//===---------- Linux implementation of the shm_open function -------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/sys/mman/shm_open.h"
+#include "llvm-libc-macros/fcntl-macros.h"
+#include "src/fcntl/open.h"
+#include "src/sys/mman/linux/shm_common.h"
+
+namespace LIBC_NAMESPACE {
+
+static constexpr int DEFAULT_OFLAGS = O_NOFOLLOW | O_CLOEXEC | O_NONBLOCK;
+
+LLVM_LIBC_FUNCTION(int, shm_open, (const char *name, int oflags, mode_t mode)) {
+  cpp::optional<SHMPath> buffer = get_shm_name(name);
+  if (!buffer.has_value())
+    return -1;
+  return open(buffer->data(), oflags | DEFAULT_OFLAGS, mode);
----------------
nickdesaulniers wrote:

Consider inverting this conditional, by using C++17 init-statement in if statement (https://en.cppreference.com/w/cpp/language/if) example: https://godbolt.org/z/7zTGMPoGY

https://github.com/llvm/llvm-project/pull/84974