[libc-commits] [libc] bae47d4 - [libc] fix another build failure from using limits.h (#84827)

via libc-commits libc-commits at lists.llvm.org
Tue Mar 12 08:38:38 PDT 2024


Author: Nick Desaulniers
Date: 2024-03-12T08:38:34-07:00
New Revision: bae47d48b632a4fa1dce5591bc0783360cf69e28

URL: https://github.com/llvm/llvm-project/commit/bae47d48b632a4fa1dce5591bc0783360cf69e28
DIFF: https://github.com/llvm/llvm-project/commit/bae47d48b632a4fa1dce5591bc0783360cf69e28.diff

LOG: [libc] fix another build failure from using limits.h (#84827)

My GCC build is failing with issues similar why we added our own. Looks
like
we missed one spot. See also:

commit 72ce62941579 ("[libc] Add C23 limits.h header. (#78887)")

Added: 
    

Modified: 
    libc/test/src/__support/CMakeLists.txt
    libc/test/src/__support/integer_to_string_test.cpp

Removed: 
    


################################################################################
diff  --git a/libc/test/src/__support/CMakeLists.txt b/libc/test/src/__support/CMakeLists.txt
index 91dd0dc4decfe0..51b897f8b595a8 100644
--- a/libc/test/src/__support/CMakeLists.txt
+++ b/libc/test/src/__support/CMakeLists.txt
@@ -78,6 +78,7 @@ add_libc_test(
   SRCS
     integer_to_string_test.cpp
   DEPENDS
+    libc.src.__support.CPP.limits
     libc.src.__support.CPP.string_view
     libc.src.__support.integer_literals
     libc.src.__support.integer_to_string

diff  --git a/libc/test/src/__support/integer_to_string_test.cpp b/libc/test/src/__support/integer_to_string_test.cpp
index a2a80c81b9f69f..270fddd828b680 100644
--- a/libc/test/src/__support/integer_to_string_test.cpp
+++ b/libc/test/src/__support/integer_to_string_test.cpp
@@ -6,6 +6,7 @@
 //
 //===----------------------------------------------------------------------===//
 
+#include "src/__support/CPP/limits.h"
 #include "src/__support/CPP/span.h"
 #include "src/__support/CPP/string_view.h"
 #include "src/__support/UInt.h"
@@ -15,8 +16,6 @@
 
 #include "test/UnitTest/Test.h"
 
-#include "limits.h"
-
 using LIBC_NAMESPACE::IntegerToString;
 using LIBC_NAMESPACE::cpp::span;
 using LIBC_NAMESPACE::cpp::string_view;


        


More information about the libc-commits mailing list