[libc-commits] [libc] [libc] fix another build failure from using limits.h (PR #84827)

via libc-commits libc-commits at lists.llvm.org
Mon Mar 11 13:36:37 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libc

Author: Nick Desaulniers (nickdesaulniers)

<details>
<summary>Changes</summary>

My GCC build is failing with issues similar why we added our own.  Looks like
we missed one spot. See also:

commit 72ce62941579 ("[libc] Add C23 limits.h header. (#<!-- -->78887)")


---
Full diff: https://github.com/llvm/llvm-project/pull/84827.diff


1 Files Affected:

- (modified) libc/test/src/__support/integer_to_string_test.cpp (+1-2) 


``````````diff
diff --git a/libc/test/src/__support/integer_to_string_test.cpp b/libc/test/src/__support/integer_to_string_test.cpp
index a2a80c81b9f69f..270fddd828b680 100644
--- a/libc/test/src/__support/integer_to_string_test.cpp
+++ b/libc/test/src/__support/integer_to_string_test.cpp
@@ -6,6 +6,7 @@
 //
 //===----------------------------------------------------------------------===//
 
+#include "src/__support/CPP/limits.h"
 #include "src/__support/CPP/span.h"
 #include "src/__support/CPP/string_view.h"
 #include "src/__support/UInt.h"
@@ -15,8 +16,6 @@
 
 #include "test/UnitTest/Test.h"
 
-#include "limits.h"
-
 using LIBC_NAMESPACE::IntegerToString;
 using LIBC_NAMESPACE::cpp::span;
 using LIBC_NAMESPACE::cpp::string_view;

``````````

</details>


https://github.com/llvm/llvm-project/pull/84827


More information about the libc-commits mailing list