[libc-commits] [libc] [libc][stdbit] Add C tests for stdbit generic macros. (PR #84670)

via libc-commits libc-commits at lists.llvm.org
Mon Mar 11 11:25:36 PDT 2024


lntue wrote:

> Ah, so we can test in C mode! Great!
> 
> Do you mind creating distinct PRs for the changes to test/include vs refactoring the type-generic macros?
> 
> The type-generic macros need to be rewritten in a different way to fix the TODO at the top of libc/include/llvm-libc-macros/stdbit-macros.h. They need to be an if/else nest using sizeof and explicit casts in order to support `_BitInt`. Either you or I can do that change, which is orthogonal to the nice changes you made to the tests.

Thanks for letting me know!  I've removed the `stdbit-macros.h` changes and only add the C tests in this PR.

https://github.com/llvm/llvm-project/pull/84670


More information about the libc-commits mailing list