[libc-commits] [libc] [libc][stdbit] Update generated stdbit generic macros and add C tests. (PR #84670)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Mon Mar 11 09:16:01 PDT 2024


https://github.com/nickdesaulniers commented:

Ah, so we can test in C mode! Great!

Do you mind creating distinct PRs for the changes to test/include vs refactoring the type-generic macros?

The type-generic macros need to be rewritten in a different way to fix the TODO at the top of libc/include/llvm-libc-macros/stdbit-macros.h.  They need to be an if/else nest using sizeof and explicit casts in order to support `_BitInt`.  Either you or I can do that change, which is orthogonal to the nice changes you made to the tests.

https://github.com/llvm/llvm-project/pull/84670


More information about the libc-commits mailing list