[libc-commits] [libc] [libc][stdfix] Add integer square root with fixed point output functions. (PR #83959)

[via libc-commits]

zeroomega wrote:

Hi,

We think this change broke the runtime build for armv6 baremetal target:

```
[4529/4546] Performing build step for 'runtimes-armv6m-unknown-eabi'
[1/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/__llvm-libc-common.h
[2/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-macros/generic-error-number-macros.h
[3/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-macros/null-macro.h
[4/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-macros/fenv-macros.h
[5/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-macros/file-seek-macros.h
[6/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-macros/stdint-macros.h
[7/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-macros/float-macros.h
[8/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-macros/limits-macros.h
[9/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-macros/offsetof-macro.h
[10/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-macros/stdio-macros.h
[11/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-macros/stdlib-macros.h
[12/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-macros/inttypes-macros.h
[13/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-macros/stdfix-macros.h
[14/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-types/off64_t.h
[15/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-types/size_t.h
[16/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-types/ssize_t.h
[17/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-types/__bsearchcompare_t.h
[18/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-types/__qsortcompare_t.h
[19/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-types/__qsortrcompare_t.h
[20/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-types/double_t.h
[21/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-types/div_t.h
[22/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-types/ldiv_t.h
[23/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-types/lldiv_t.h
[24/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-types/FILE.h
[25/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-types/fenv_t.h
[26/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-types/fexcept_t.h
[27/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-types/float_t.h
[28/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-types/imaxdiv_t.h
[29/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-types/__atexithandler_t.h
[30/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-macros/containerof-macro.h
[31/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/llvm-libc-types/float128.h
[32/337] Generating /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/ctype.h
FAILED: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/ctype.h 
cd /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/include && /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/bin/libc-hdrgen -o /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-y7uc9ze5/include/armv6m-unknown-eabi/ctype.h --header ctype.h --def /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/include/ctype.h.def -I /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc --e=__assert_fail --e=isalnum --e=isalpha --e=isascii --e=isblank --e=iscntrl --e=isdigit --e=isgraph --e=islower --e=isprint --e=ispunct --e=isspace --e=isupper --e=isxdigit --e=toascii --e=tolower --e=toupper --e=__stack_chk_fail --e=errno --e=bcmp --e=bcopy --e=bzero --e=memccpy --e=memchr --e=memcmp --e=memcpy --e=memmem --e=memmove --e=mempcpy --e=memrchr --e=memset --e=stpcpy --e=stpncpy --e=strcasecmp --e=strcasestr --e=strcat --e=strchr --e=strchrnul --e=strcmp --e=strcpy --e=strcspn --e=strlcat --e=strlcpy --e=strlen --e=strncasecmp --e=strncat --e=strncmp --e=strncpy --e=strnlen --e=strpbrk --e=strrchr --e=strspn --e=strstr --e=strtok --e=strtok_r --e=imaxabs --e=imaxdiv --e=strtoimax --e=strtoumax --e=sprintf --e=snprintf --e=vsprintf --e=vsnprintf --e=stdc_leading_zeros_uc --e=stdc_leading_zeros_us --e=stdc_leading_zeros_ui --e=stdc_leading_zeros_ul --e=stdc_leading_zeros_ull --e=stdc_leading_ones_uc --e=stdc_leading_ones_us --e=stdc_leading_ones_ui --e=stdc_leading_ones_ul --e=stdc_leading_ones_ull --e=stdc_trailing_zeros_uc --e=stdc_trailing_zeros_us --e=stdc_trailing_zeros_ui --e=stdc_trailing_zeros_ul --e=stdc_trailing_zeros_ull --e=stdc_trailing_ones_uc --e=stdc_trailing_ones_us --e=stdc_trailing_ones_ui --e=stdc_trailing_ones_ul --e=stdc_trailing_ones_ull --e=stdc_first_leading_zero_uc --e=stdc_first_leading_zero_us --e=stdc_first_leading_zero_ui --e=stdc_first_leading_zero_ul --e=stdc_first_leading_zero_ull --e=stdc_first_leading_one_uc --e=stdc_first_leading_one_us --e=stdc_first_leading_one_ui --e=stdc_first_leading_one_ul --e=stdc_first_leading_one_ull --e=stdc_first_trailing_zero_uc --e=stdc_first_trailing_zero_us --e=stdc_first_trailing_zero_ui --e=stdc_first_trailing_zero_ul --e=stdc_first_trailing_zero_ull --e=stdc_first_trailing_one_uc --e=stdc_first_trailing_one_us --e=stdc_first_trailing_one_ui --e=stdc_first_trailing_one_ul --e=stdc_first_trailing_one_ull --e=abort --e=abs --e=atoi --e=atof --e=atol --e=atoll --e=bsearch --e=div --e=labs --e=ldiv --e=llabs --e=lldiv --e=qsort --e=strtod --e=strtof --e=strtol --e=strtold --e=strtoll --e=strtoul --e=strtoull --e=feclearexcept --e=fedisableexcept --e=feenableexcept --e=fegetenv --e=fegetexcept --e=fegetexceptflag --e=fegetround --e=feholdexcept --e=fesetenv --e=fesetexceptflag --e=fesetround --e=feraiseexcept --e=fetestexcept --e=feupdateenv --e=acosf --e=acoshf --e=asinf --e=asinhf --e=atanf --e=atanhf --e=ceil --e=ceilf --e=ceill --e=copysign --e=copysignf --e=copysignl --e=cosf --e=coshf --e=erff --e=exp --e=exp10 --e=exp10f --e=exp2 --e=exp2f --e=expf --e=expm1 --e=expm1f --e=fabs --e=fabsf --e=fabsl --e=fdim --e=fdimf --e=fdiml --e=floor --e=floorf --e=floorl --e=fma --e=fmaf --e=fmax --e=fmaxf --e=fmaxl --e=fmin --e=fminf --e=fminl --e=fmod --e=fmodf --e=frexp --e=frexpf --e=frexpl --e=hypot --e=hypotf --e=ilogb --e=ilogbf --e=ilogbl --e=ldexp --e=ldexpf --e=ldexpl --e=llrint --e=llrintf --e=llrintl --e=llround --e=llroundf --e=llroundl --e=log --e=log10 --e=log10f --e=log1p --e=log1pf --e=log2 --e=log2f --e=logb --e=logbf --e=logbl --e=logf --e=lrint --e=lrintf --e=lrintl --e=lround --e=lroundf --e=lroundl --e=modf --e=modff --e=modfl --e=nan --e=nanf --e=nanl --e=nearbyint --e=nearbyintf --e=nearbyintl --e=nextafter --e=nextafterf --e=nextafterl --e=nexttoward --e=nexttowardf --e=nexttowardl --e=powf --e=remainder --e=remainderf --e=remainderl --e=remquo --e=remquof --e=remquol --e=rint --e=rintf --e=
--e=abslr --e=roundhk --e=roundhr --e=roundk --e=roundr --e=roundlk --e=roundlr --e=rounduhk --e=rounduhr --e=rounduk --e=roundur --e=roundulk --e=roundulr --e=sqrtuhk --e=sqrtuhr --e=sqrtuk --e=sqrtur --e=sqrtulr --e=uhksqrtus --e=uksqrtui /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/config/baremetal/api.td
Included from /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/config/baremetal/api.td:5:
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/spec/llvm_libc_ext.td:43:25: error: Variable not defined: 'CpuSetT'
      [PidT, SizeTType, CpuSetT], // Types
```
See llvm build https://lab.llvm.org/buildbot/#/builders/98/builds/34456 . Could you revert your change and land it later after fixing it?

C.C. @petrhosek @mysterymath 

https://github.com/llvm/llvm-project/pull/83959