[libc-commits] [libc] [libc][stdfix] Add integer square root with fixed point output functions. (PR #83959)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Tue Mar 5 10:39:11 PST 2024


================
@@ -55,6 +55,9 @@ def StdcExt : StandardSpec<"stdc_ext"> {
           GuardedFunctionSpec<"sqrtuhk", RetValSpec<UnsignedShortAccumType>, [ArgSpec<UnsignedShortAccumType>], "LIBC_COMPILER_HAS_FIXED_POINT">,
           GuardedFunctionSpec<"sqrtuk", RetValSpec<UnsignedAccumType>, [ArgSpec<UnsignedAccumType>], "LIBC_COMPILER_HAS_FIXED_POINT">,
           GuardedFunctionSpec<"sqrtulk", RetValSpec<UnsignedLongAccumType>, [ArgSpec<UnsignedLongAccumType>], "LIBC_COMPILER_HAS_FIXED_POINT">,
+
+          GuardedFunctionSpec<"uhksqrtus", RetValSpec<UnsignedShortAccumType>, [ArgSpec<UnsignedShortType>], "LIBC_COMPILER_HAS_FIXED_POINT">,
----------------
nickdesaulniers wrote:

right, I would prefer stronger language / guarantees between "implemented against a spec" vs straight up "extension."

both in documentation and in our headergen files as @michaelrj-google suggested.

https://github.com/llvm/llvm-project/pull/83959


More information about the libc-commits mailing list