[libc-commits] [libc] [libc] Fix Cppcheck Issues (PR #96999)
Joseph Huber via libc-commits
libc-commits at lists.llvm.org
Fri Jun 28 04:52:22 PDT 2024
jhuber6 wrote:
> > @jameshu15869 Do you think we can turn on most of the warning flags together with `Werror` for `benchmark` folder similar to our `src` folder?
> > https://github.com/llvm/llvm-project/blob/main/libc/cmake/modules/LLVMLibCCompileOptionRules.cmake#L73-L78
>
> I don't think I built LLVM using the `LIBC_WNO_ERROR` option, so I don't think I am compiling with `-Werror` right now.
>
> @jhuber6 do you think `-Werror` should show up in my compile flags?
We currently don't build with `-Werror` for the tests, that being said there probably shouldn't be any warnings.
https://github.com/llvm/llvm-project/pull/96999
More information about the libc-commits
mailing list