[libc-commits] [libc] [libc][math] Implement double precision cos correctly rounded to all rounding modes. (PR #96591)

via libc-commits libc-commits at lists.llvm.org
Tue Jun 25 05:46:59 PDT 2024


lntue wrote:

> is that ready for review? I get several failures with the core-math test suite:
> 
> ```
> Running worst cases check in --rndn mode...
> FAIL x=0x1.00a33764a0a83p-7 ref=0x1.fffbfae5fd5b9p-1 z=0x1.fffbfae5fd5b8p-1
> Running worst cases check in --rndz mode...
> FAIL x=0x1.fe81868fc47fep+1 ref=-0x1.532a58337e7c7p-1 z=-0x1.532a58337e7c6p-1
> Running worst cases check in --rndu mode...
> FAIL x=0x1.0da8cc189b47dp-10 ref=0x1.ffffee3f3d56cp-1 z=0x1.ffffee3f3d56dp-1
> Running worst cases check in --rndd mode...
> FAIL x=0x1.da1838053b866p+5 ref=-0x1.d1b955a0137fep-1 z=-0x1.d1b955a0137ffp-1
> ```

@zimmmermann6 Hi Paul, the PR is ready for review, and it could pass those test values on my computer.  I included them to our unit tests now.  Do you mind clearing the build folder and try it again?  Thanks!

https://github.com/llvm/llvm-project/pull/96591


More information about the libc-commits mailing list