[libc-commits] [libc] [libc][math][c23] Add f16divf C23 math function (PR #96131)

via libc-commits libc-commits at lists.llvm.org
Mon Jun 24 09:56:58 PDT 2024


================
@@ -0,0 +1,180 @@
+//===-- Division of IEEE 754 floating-point numbers -------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC___SUPPORT_FPUTIL_GENERIC_DIV_H
+#define LLVM_LIBC_SRC___SUPPORT_FPUTIL_GENERIC_DIV_H
+
+#include "hdr/fenv_macros.h"
+#include "src/__support/CPP/bit.h"
+#include "src/__support/CPP/type_traits.h"
+#include "src/__support/FPUtil/FEnvImpl.h"
+#include "src/__support/FPUtil/FPBits.h"
+#include "src/__support/FPUtil/dyadic_float.h"
+#include "src/__support/FPUtil/rounding_mode.h"
+
+namespace LIBC_NAMESPACE::fputil::generic {
+
+template <typename OutType, typename InType>
+cpp::enable_if_t<cpp::is_floating_point_v<OutType> &&
+                     cpp::is_floating_point_v<InType> &&
+                     sizeof(OutType) <= sizeof(InType),
+                 OutType>
+div(InType x, InType y) {
+  using OutFPBits = FPBits<OutType>;
+  using OutStorageType = typename OutFPBits::StorageType;
+  using InFPBits = FPBits<InType>;
+  using InStorageType = typename InFPBits::StorageType;
+  using DyadicFloat =
+      DyadicFloat<cpp::bit_ceil(static_cast<size_t>(InFPBits::FRACTION_LEN))>;
+  using DyadicMantissaType = typename DyadicFloat::MantissaType;
+
+  // +1 for the implicit bit.
+  constexpr int DYADIC_EXTRA_MANTISSA_LEN =
+      DyadicMantissaType::BITS - (InFPBits::FRACTION_LEN + 1);
+  // +1 for the extra fractional bit in q.
+  constexpr int Q_EXTRA_FRACTION_LEN =
+      InFPBits::FRACTION_LEN + 1 - OutFPBits::FRACTION_LEN;
+
+  InFPBits x_bits(x);
+  InFPBits y_bits(y);
+
+  if (x_bits.is_nan() || y_bits.is_nan()) {
+    if (x_bits.is_signaling_nan() || y_bits.is_signaling_nan())
----------------
overmighty wrote:

Even with the changes to `DyadicFloat::operator T()`, the new implementation with fewer iterations is still faster than the previous one:

```
 Performance tests with inputs in denormal range:
-- My function --
     Total time      : 232472260 ns 
     Average runtime : 46.4944 ns/op 
     Ops per second  : 21507964 op/s 
-- Other function --
     Total time      : 519384676 ns 
     Average runtime : 103.877 ns/op 
     Ops per second  : 9626785 op/s 
-- Average runtime ratio --
     Mine / Other's  : 0.447592 

 Performance tests with inputs in normal range:
-- My function --
     Total time      : 511714277 ns 
     Average runtime : 102.343 ns/op 
     Ops per second  : 9771087 op/s 
-- Other function --
     Total time      : 637747828 ns 
     Average runtime : 127.549 ns/op 
     Ops per second  : 7840097 op/s 
-- Average runtime ratio --
     Mine / Other's  : 0.802377 

 Performance tests with inputs in normal range with exponents close to each other:
-- My function --
     Total time      : 309770755 ns 
     Average runtime : 61.9541 ns/op 
     Ops per second  : 16140984 op/s 
-- Other function --
     Total time      : 512884190 ns 
     Average runtime : 102.577 ns/op 
     Ops per second  : 9748799 op/s 
-- Average runtime ratio --
     Mine / Other's  : 0.603978 
```


https://github.com/llvm/llvm-project/pull/96131


More information about the libc-commits mailing list