[libc-commits] [libc] [libc][math] Implement double precision sin correctly rounded to all rounding modes. (PR #95736)

[via libc-commits]

lntue wrote:

> > @nickdesaulniers : shall we add accuracy assertion under `#ifndef NDEBUG` guard?
> 
> Yes, I'm a big fan of `-DLLVM_ENABLE_ASSERTIONS=ON`. We also have `LIBC_ASSERT` (`src/__support/libc_assert.h`). The intention of `-DLLVM_ENABLE_ASSERTIONS=ON` is to trade some performance overhead for additional safety checks. Assertions builds are generally much faster than `-DCMAKE_BUILD_TYPE=Debug` builds of the rest of LLVM in my experience, so I usually develop with assertions enabled but not a full blow debug build (which takes longer to compiler and link).

I created an issue (https://github.com/llvm/llvm-project/issues/96452) and added a TODO to provide an exact error bound for the accurate pass and add assertion.

https://github.com/llvm/llvm-project/pull/95736