[libc-commits] [libc] [libc][math] Implement double precision sin correctly rounded to all rounding modes. (PR #95736)

[Nick Desaulniers via libc-commits]

nickdesaulniers wrote:

> @nickdesaulniers : shall we add accuracy assertion under `#ifndef NDEBUG` guard?

Yes, I'm a big fan of `-DLLVM_ENABLE_ASSERTIONS=ON`.  We also have `LIBC_ASSERT` (`src/__support/libc_assert.h`).  The intention of `-DLLVM_ENABLE_ASSERTIONS=ON` is to trade some performance overhead for additional safety checks.  Assertions builds are generally much faster than `-DCMAKE_BUILD_TYPE=Debug` builds of the rest of LLVM in my experience, so I usually develop with assertions enabled but not a full blow debug build (which takes longer to compiler and link).

https://github.com/llvm/llvm-project/pull/95736