[libc-commits] [libc] [libc][fcntl] fix -Wshorten-64-to-32 for 32b ARM (PR #95945)

via libc-commits libc-commits at lists.llvm.org
Tue Jun 18 09:56:41 PDT 2024


lntue wrote:

> This patch LGTM.
> 
> But @lntue mentioned there may be other problems.

The fix for this part is fine for me.  The other problem in the same function that I have question is
```
if (static_cast<unsigned long>(retVal) <= -4096UL)
      return fex.type == F_OWNER_PGRP ? -fex.pid : fex.pid;
```
which will treat erroneous condition `retval < -4096` the same as ok condition `retval >= 0`.  We should continue the discussion of that one in https://github.com/llvm/llvm-project/issues/95570.

https://github.com/llvm/llvm-project/pull/95945


More information about the libc-commits mailing list