[libc-commits] [libc] [libc] Temporarily disable SCHED_FIFO and SCHED_RR tests (PR #95562)

via libc-commits libc-commits at lists.llvm.org
Fri Jun 14 09:37:27 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libc

Author: OverMighty (overmighty)

<details>
<summary>Changes</summary>

These tests fail on Arch Linux, where setting these scheduling policies
succeeds even when not running as root.


---
Full diff: https://github.com/llvm/llvm-project/pull/95562.diff


1 Files Affected:

- (modified) libc/test/src/sched/param_and_scheduler_test.cpp (+5-3) 


``````````diff
diff --git a/libc/test/src/sched/param_and_scheduler_test.cpp b/libc/test/src/sched/param_and_scheduler_test.cpp
index 8e81f2ed1517f..7cf553f1af525 100644
--- a/libc/test/src/sched/param_and_scheduler_test.cpp
+++ b/libc/test/src/sched/param_and_scheduler_test.cpp
@@ -145,9 +145,11 @@ class SchedTest : public LIBC_NAMESPACE::testing::Test {
   using LlvmLibcSchedTest = SchedTest;                                         \
   TEST_F(LlvmLibcSchedTest, Sched_##policy) { testSched(policy, can_set); }
 
-// Root is required to set these policies.
-LIST_SCHED_TESTS(SCHED_FIFO, LIBC_NAMESPACE::getuid() == 0)
-LIST_SCHED_TESTS(SCHED_RR, LIBC_NAMESPACE::getuid() == 0)
+// Temporarily disabled as these tests are failing on Arch Linux where
+// scheduling policy setting succeeds without running as root.
+// // Root is required to set these policies.
+// LIST_SCHED_TESTS(SCHED_FIFO, LIBC_NAMESPACE::getuid() == 0)
+// LIST_SCHED_TESTS(SCHED_RR, LIBC_NAMESPACE::getuid() == 0)
 
 // No root is required to set these policies.
 LIST_SCHED_TESTS(SCHED_OTHER, true)

``````````

</details>


https://github.com/llvm/llvm-project/pull/95562


More information about the libc-commits mailing list