[libc-commits] [libc] [libc][test] Fix TEST->TEST_F typo in getenv_and_setenv_test.cpp (PR #94304)

via libc-commits libc-commits at lists.llvm.org
Mon Jun 3 19:05:28 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libc

Author: Jordan Rupprecht (rupprecht)

<details>
<summary>Changes</summary>

This manifests as `AddressSanitizer: stack-use-after-return` w/o this change. The `~CheckFEnv()` method of checking fenv seems to only work for test fixtures.

---
Full diff: https://github.com/llvm/llvm-project/pull/94304.diff


1 Files Affected:

- (modified) libc/test/src/fenv/getenv_and_setenv_test.cpp (+1-1) 


``````````diff
diff --git a/libc/test/src/fenv/getenv_and_setenv_test.cpp b/libc/test/src/fenv/getenv_and_setenv_test.cpp
index 7257e75cb421a..8fc2787ecb5b1 100644
--- a/libc/test/src/fenv/getenv_and_setenv_test.cpp
+++ b/libc/test/src/fenv/getenv_and_setenv_test.cpp
@@ -41,7 +41,7 @@ TEST_F(LlvmLibcFEnvTest, GetEnvAndSetEnv) {
   }
 }
 
-TEST(LlvmLibcFenvTest, Set_FE_DFL_ENV) {
+TEST_F(LlvmLibcFEnvTest, Set_FE_DFL_ENV) {
   // We will disable all exceptions to prevent invocation of the exception
   // handler.
   LIBC_NAMESPACE::fputil::disable_except(FE_ALL_EXCEPT);

``````````

</details>


https://github.com/llvm/llvm-project/pull/94304


More information about the libc-commits mailing list