[libc-commits] [libc] [libc][math][c23] Add dadd{l, f128} and ddiv{l, f128} C23 math functions (PR #100456)

[via libc-commits]

================
@@ -0,0 +1,13 @@
+//===-- Unittests for ddivl -----------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "DivTest.h"
+
+#include "src/math/ddivl.h"
+
+LIST_ADD_TESTS(double, long double, LIBC_NAMESPACE::ddivl)
----------------
overmighty wrote:

You wrote `LIST_ADD_TESTS` instead of `LIST_DIV_TESTS`, so the preprocessor didn't replace the macro, and Clang thought you were declaring a function and that `LIBC_NAMESPACE::ddivl` was meant to be the type of an unnamed function parameter.

The log view on the Buildkite website only displays the last 2 MB of data. You can view the error messages if you download the raw log:

<details><summary>Relevant part of the Buildkite log</summary>
<pre><code>_bk;t=1722365638958
[2610/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmaxf_test.__unit__.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmaxf_test.cpp.o_bk;t=1722365638959
[2611/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.ldexpl_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638959
[2611/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmaxf_test.__unit__.__NO_FMA_OPT.__build__.dir/fmaxf_test.cpp.o_bk;t=1722365638959
[2612/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.ilogbl_test.__unit__.__build___bk;t=1722365638959
[2612/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmaxf_test.__unit__.__NO_FMA_OPT.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmaxf_test.cpp.o_bk;t=1722365638962
[2613/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.ldexp_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638962
[2613/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmax_test.__unit__.__build__.dir/fmax_test.cpp.o_bk;t=1722365638963
[2614/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.ldexpf_test.__unit__.__build___bk;t=1722365638963
[2614/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmax_test.__unit__.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmax_test.cpp.o_bk;t=1722365638963
[2615/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.copysignf_test.__unit__.__build___bk;t=1722365638964
[2615/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmax_test.__unit__.__NO_FMA_OPT.__build__.dir/fmax_test.cpp.o_bk;t=1722365638964
[2616/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.copysignf_test.__unit__.__NO_FMA_OPT.__NO_MISC_MATH_BASIC_OPS_OPT.__build___bk;t=1722365638964
[2616/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmax_test.__unit__.__NO_FMA_OPT.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmax_test.cpp.o_bk;t=1722365638964
[2617/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.frexpl_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638964
[2617/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmaxl_test.__unit__.__build__.dir/fmaxl_test.cpp.o_bk;t=1722365638965
[2618/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.ilogbf_test.__unit__.__build___bk;t=1722365638965
[2618/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmaxl_test.__unit__.__NO_FMA_OPT.__build__.dir/fmaxl_test.cpp.o_bk;t=1722365638966
[2619/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmin_test.__unit__.__NO_FMA_OPT.__build__.dir/fmin_test.cpp.o_bk;t=1722365638966
[2619/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fmin_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638967
[2620/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmin_test.__unit__.__NO_FMA_OPT.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmin_test.cpp.o_bk;t=1722365638967
[2620/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fmin_test.__unit__.__NO_FMA_OPT.__NO_MISC_MATH_BASIC_OPS_OPT.__build___bk;t=1722365638967
[2621/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.frexpf_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638967
[2621/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.sqrtf_test.__unit__.__build__.dir/sqrtf_test.cpp.o_bk;t=1722365638968
[2622/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.ilogbf_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638968
[2622/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.sqrt_test.__unit__.__build__.dir/sqrt_test.cpp.o_bk;t=1722365638968
[2623/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.ilogbl_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638968
[2623/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.sqrtl_test.__unit__.__build__.dir/sqrtl_test.cpp.o_bk;t=1722365638973
[2624/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fminl_test.__unit__.__NO_FMA_OPT.__build__.dir/fminl_test.cpp.o_bk;t=1722365638973
[2624/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fminl_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638978
[2625/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.ldexp_test.__unit__.__build___bk;t=1722365638978
[2625/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.generic_sqrtf_test.__unit__.__build__.dir/generic_sqrtf_test.cpp.o_bk;t=1722365638979
[2626/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmin_test.__unit__.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmin_test.cpp.o_bk;t=1722365638979
[2626/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fmin_test.__unit__.__NO_MISC_MATH_BASIC_OPS_OPT.__build___bk;t=1722365638980
[2627/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.ilogb_test.__unit__.__build___bk;t=1722365638980
[2627/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.generic_sqrtf_test.__unit__.__NO_FMA_OPT.__build__.dir/generic_sqrtf_test.cpp.o_bk;t=1722365638986
[2628/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmin_test.__unit__.__build__.dir/fmin_test.cpp.o_bk;t=1722365638986
[2628/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fmin_test.__unit__.__build___bk;t=1722365638987
[2629/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.ilogb_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638987
[2629/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.generic_sqrt_test.__unit__.__build__.dir/generic_sqrt_test.cpp.o_bk;t=1722365638989
[2630/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.logb_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638989
[2630/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.generic_sqrt_test.__unit__.__NO_FMA_OPT.__build__.dir/generic_sqrt_test.cpp.o_bk;t=1722365638990
[2631/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fminl_test.__unit__.__build__.dir/fminl_test.cpp.o_bk;t=1722365638990
[2631/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fminl_test.__unit__.__build___bk;t=1722365638992
[2632/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmaxf_test.__unit__.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmaxf_test.cpp.o_bk;t=1722365638992
[2632/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fmaxf_test.__unit__.__NO_MISC_MATH_BASIC_OPS_OPT.__build___bk;t=1722365638993
[2633/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmaxf_test.__unit__.__NO_FMA_OPT.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmaxf_test.cpp.o_bk;t=1722365638993
[2633/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fmaxf_test.__unit__.__NO_FMA_OPT.__NO_MISC_MATH_BASIC_OPS_OPT.__build___bk;t=1722365638994
[2634/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmax_test.__unit__.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmax_test.cpp.o_bk;t=1722365638995
[2634/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fmax_test.__unit__.__NO_MISC_MATH_BASIC_OPS_OPT.__build___bk;t=1722365638996
[2635/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmax_test.__unit__.__NO_FMA_OPT.__build__.dir/fmax_test.cpp.o_bk;t=1722365638997
[2635/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fmax_test.__unit__.__NO_FMA_OPT.__build___bk;t=1722365638999
[2636/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmax_test.__unit__.__NO_FMA_OPT.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmax_test.cpp.o_bk;t=1722365638999
[2636/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fmax_test.__unit__.__NO_FMA_OPT.__NO_MISC_MATH_BASIC_OPS_OPT.__build___bk;t=1722365639000
[2637/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmaxl_test.__unit__.__build__.dir/fmaxl_test.cpp.o_bk;t=1722365639000
[2637/6331] Linking CXX executable projects/libc/test/src/math/libc.test.src.math.fmaxl_test.__unit__.__build___bk;t=1722365639002
[2638/6331] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.ddivl_test.__unit__.__build__.dir/ddivl_test.cpp.o_bk;t=1722365639002
_bk;t=1722365639002FAILED: projects/libc/test/src/math/CMakeFiles/libc.test.src.math.ddivl_test.__unit__.__build__.dir/ddivl_test.cpp.o 
_bk;t=1722365639002CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DLIBC_NAMESPACE=__llvm_libc_20_0_0_git -I/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-xmlqb-1/llvm-project/github-pull-requests/build/projects/libc/test/src/math -I/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-xmlqb-1/llvm-project/github-pull-requests/libc/test/src/math -I/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-xmlqb-1/llvm-project/github-pull-requests/libc -isystem /var/lib/buildkite-agent/builds/linux-56-59b8f5d88-xmlqb-1/llvm-project/github-pull-requests/build/projects/libc/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -UNDEBUG -mavx2 -mfma -fpie -march=native -fno-exceptions -fno-rtti -std=c++17 -MD -MT projects/libc/test/src/math/CMakeFiles/libc.test.src.math.ddivl_test.__unit__.__build__.dir/ddivl_test.cpp.o -MF projects/libc/test/src/math/CMakeFiles/libc.test.src.math.ddivl_test.__unit__.__build__.dir/ddivl_test.cpp.o.d -o projects/libc/test/src/math/CMakeFiles/libc.test.src.math.ddivl_test.__unit__.__build__.dir/ddivl_test.cpp.o -c /var/lib/buildkite-agent/builds/linux-56-59b8f5d88-xmlqb-1/llvm-project/github-pull-requests/libc/test/src/math/ddivl_test.cpp
_bk;t=1722365639003/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-xmlqb-1/llvm-project/github-pull-requests/libc/test/src/math/ddivl_test.cpp:13:53: error: no type named 'ddivl' in namespace '__llvm_libc_20_0_0_git'
_bk;t=1722365639003LIST_ADD_TESTS(double, long double, LIBC_NAMESPACE::ddivl)
_bk;t=1722365639003                                    ~~~~~~~~~~~~~~~~^
_bk;t=1722365639003/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-xmlqb-1/llvm-project/github-pull-requests/libc/test/src/math/ddivl_test.cpp:13:59: error: expected function body after function declarator
_bk;t=1722365639003LIST_ADD_TESTS(double, long double, LIBC_NAMESPACE::ddivl)
_bk;t=1722365639003                                                          ^
_bk;t=17223656390032 errors generated.
</code></pre></details>

By the way, I tried to change it to `LIST_DIV_TESTS` and then the MPFR test failed due to incorrect results.

https://github.com/llvm/llvm-project/pull/100456