[libc-commits] [libc] [libc][math][c23] Add dadd{l, f128} and ddiv{l, f128} C23 math functions (PR #100456)

via libc-commits libc-commits at lists.llvm.org
Mon Jul 29 13:07:39 PDT 2024


================
@@ -136,7 +136,7 @@ Basic Operations
 +------------------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+
 | fabs             | |check|          | |check|         | |check|                | |check|              | |check|                | 7.12.7.3               | F.10.4.3                   |
 +------------------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+
-| fadd             | N/A              | |check|         | |check|                | N/A                  | |check|                | 7.12.14.1              | F.10.11                    |
+| fadd             | N/A              | |check|                                 | N/A                  |                        | 7.12.14.1              | F.10.11                     |
----------------
overmighty wrote:

Kind of nitpicky, but technically I think this should be in its own PR, since:

> Once you have a patch ready, it is time to submit it. The patch should:
> - [...]
> - not contain any unrelated changes
> - be an isolated change. Independent changes should be submitted as separate patches as this makes reviewing easier.

https://llvm.org/docs/Contributing.html#how-to-submit-a-patch

I don't know if this gets a pass for being such a small change or not. @lntue

https://github.com/llvm/llvm-project/pull/100456


More information about the libc-commits mailing list