[libc-commits] [libc] [libc] fuzz test for heap_sort (PR #100826)

via libc-commits libc-commits at lists.llvm.org
Sun Jul 28 06:19:51 PDT 2024


================
@@ -0,0 +1,53 @@
+//===-- heap_sort_fuzz.cpp ----------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+///
+/// Fuzzing test for llvm-libc heap_sort implementation.
+///
+//===----------------------------------------------------------------------===//
+
+#include "src/stdlib/heap_sort.h"
+#include <stdint.h>
+
+static int int_compare(const void *l, const void *r) {
+  int li = *reinterpret_cast<const int *>(l);
+  int ri = *reinterpret_cast<const int *>(r);
+  if (li == ri)
+    return 0;
+  else if (li > ri)
+    return 1;
+  else
+    return -1;
----------------
overmighty wrote:

Nit: from the LLVM code style:

> Don’t use `else` after a `return`

https://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return

```suggestion
  if (li == ri)
    return 0;
  if (li > ri)
    return 1;
  return -1;
```

https://github.com/llvm/llvm-project/pull/100826


More information about the libc-commits mailing list