[libc-commits] [libc] [libc][RISCV] Add naked attribute to setjmp/longjmp (PR #100036)

Paul Kirth via libc-commits libc-commits at lists.llvm.org
Tue Jul 23 10:12:48 PDT 2024


ilovepi wrote:

> LGTM but please wait for @michaelrj-google @lntue or @petrhosek to give the go-ahead.
> 
> There were some discussions about these functions in the past so better to double-check with them first.

Happy to wait, but `naked` is already on the ARM implementation, and AFAICT is required on any of these functions. TBH, I'd prefer these to be implemented in assembly files, so that we don't have to worry about it doing the right thing.



https://github.com/llvm/llvm-project/pull/100036


More information about the libc-commits mailing list