[libc-commits] [libc] [libc] Enable bind test for riscv (PR #100132)

Mikhail R. Gadelha via libc-commits libc-commits at lists.llvm.org
Tue Jul 23 07:39:22 PDT 2024


https://github.com/mikhailramalho created https://github.com/llvm/llvm-project/pull/100132

The bind test was failing in the rv32 build bot because of how the build bot was setup to run the tests: we were using shared directories between the host and qemu and the bind functions was trying to create a file in this directory, thus creating it in the host machine.

The OS was returning "-1 ENXIO (No such device or address)", so we changed the rv32 buildbot to copy the binaries to qemu and dropped the shared directories feature.

A clean run (where all tests need to be copied to qemu) is taking 7 min, up from 3 min. Incremental runs still run in 3 min.

>From 1a2e5d5302ebfef739a103fbf73fa340d7848e63 Mon Sep 17 00:00:00 2001
From: "Mikhail R. Gadelha" <mikhail at igalia.com>
Date: Tue, 23 Jul 2024 11:32:08 -0300
Subject: [PATCH] [libc] Enable bind test for riscv

The bind test was failing in the rv32 build bot because of how the build
bot was setup to run the tests: we were using shared directories between
the host and qemu and the bind functions was trying to create a file in
this directory, thus creating it in the host machine.

The OS was returning "-1 ENXIO (No such device or address)", so we
changed the rv32 buildbot to copy the binaries to qemu and dropped the
shared directories feature.

A clean run (where all tests need to be copied to qemu) is taking 7 min,
up from 3 min. Incremental runs still run in 3 min.
---
 libc/config/linux/riscv/entrypoints.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index 6ab90771802fd..597aeb361afe4 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -856,6 +856,7 @@ if(LLVM_LIBC_FULL_BUILD)
     libc.src.sys.select.select
 
     # sys/socket.h entrypoints
+    libc.src.sys.socket.bind
     libc.src.sys.socket.socket
   )
 endif()



More information about the libc-commits mailing list