[libc-commits] [libc] bc4c3bf - [libc] Remove special case handing around test case that was fixed

Joseph Huber via libc-commits libc-commits at lists.llvm.org
Mon Jul 22 06:44:08 PDT 2024


Author: Joseph Huber
Date: 2024-07-22T08:44:02-05:00
New Revision: bc4c3bf1b75fec183e2616d6688aa155d6aada74

URL: https://github.com/llvm/llvm-project/commit/bc4c3bf1b75fec183e2616d6688aa155d6aada74
DIFF: https://github.com/llvm/llvm-project/commit/bc4c3bf1b75fec183e2616d6688aa155d6aada74.diff

LOG: [libc] Remove special case handing around test case that was fixed

Summary:
I needed to hack something around this for a previous backend bug, it's
since been fixed as far as I'm aware.

Added: 
    

Modified: 
    libc/test/src/__support/blockstore_test.cpp

Removed: 
    


################################################################################
diff  --git a/libc/test/src/__support/blockstore_test.cpp b/libc/test/src/__support/blockstore_test.cpp
index dd74ea18f2c02..de7bd72b96c80 100644
--- a/libc/test/src/__support/blockstore_test.cpp
+++ b/libc/test/src/__support/blockstore_test.cpp
@@ -183,11 +183,10 @@ TEST_F(LlvmLibcBlockStoreTest, PopulateAndIterateReverse10) {
   populate_and_iterate<4, 10, true>();
 }
 
-TEST_F(LlvmLibcBlockStoreTest, Back) { back_test<false>(); }
-
-// FIXME: Combing this test with the above test makes the AMDGPU backend
-// generate code which hangs. This should be fixed in the clang compiler.
-TEST_F(LlvmLibcBlockStoreTest, BackReverse) { back_test<true>(); }
+TEST_F(LlvmLibcBlockStoreTest, Back) {
+  back_test<false>();
+  back_test<true>();
+}
 
 TEST_F(LlvmLibcBlockStoreTest, Empty) {
   empty_test<false>();


        


More information about the libc-commits mailing list