[libc-commits] [libc] [libc][newheadergen]: adding entry_point testing (PR #99587)
via libc-commits
libc-commits at lists.llvm.org
Thu Jul 18 19:47:49 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libc
Author: None (aaryanshukla)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/99587.diff
2 Files Affected:
- (modified) libc/newhdrgen/tests/expected_output/test_header.h (-4)
- (modified) libc/newhdrgen/tests/test_integration.py (+17-12)
``````````diff
diff --git a/libc/newhdrgen/tests/expected_output/test_header.h b/libc/newhdrgen/tests/expected_output/test_header.h
index a777976134b04..6533faf284a87 100644
--- a/libc/newhdrgen/tests/expected_output/test_header.h
+++ b/libc/newhdrgen/tests/expected_output/test_header.h
@@ -40,10 +40,6 @@ _Float16 func_c(int, float) __NOEXCEPT;
_Float16 func_d(int, float) __NOEXCEPT;
#endif // LIBC_TYPES_HAS_FLOAT16
-#ifdef LIBC_TYPES_HAS_FLOAT16_AND_FLOAT128
-_Float16 func_e(float128) __NOEXCEPT;
-#endif // LIBC_TYPES_HAS_FLOAT16_AND_FLOAT128
-
extern obj object_1;
extern obj object_2;
diff --git a/libc/newhdrgen/tests/test_integration.py b/libc/newhdrgen/tests/test_integration.py
index 628a37b11c309..f9fa956077f56 100644
--- a/libc/newhdrgen/tests/test_integration.py
+++ b/libc/newhdrgen/tests/test_integration.py
@@ -8,7 +8,6 @@
class TestHeaderGenIntegration(unittest.TestCase):
def setUp(self):
-
self.output_dir = Path(
args.output_dir if args.output_dir else "libc/newhdrgen/tests/output"
)
@@ -17,19 +16,24 @@ def setUp(self):
self.source_dir = Path(__file__).resolve().parent.parent.parent.parent
- def run_script(self, yaml_file, h_def_file, output_dir):
+ def run_script(self, yaml_file, h_def_file, output_dir, entry_points):
yaml_file = self.source_dir / yaml_file
h_def_file = self.source_dir / h_def_file
+ command = [
+ "python3",
+ str(self.source_dir / "libc/newhdrgen/yaml_to_classes.py"),
+ str(yaml_file),
+ "--h_def_file",
+ str(h_def_file),
+ "--output_dir",
+ str(output_dir),
+ ]
+
+ for entry_point in entry_points:
+ command.extend(["--e", entry_point])
+
result = subprocess.run(
- [
- "python3",
- str(self.source_dir / "libc/newhdrgen/yaml_to_classes.py"),
- str(yaml_file),
- "--h_def_file",
- str(h_def_file),
- "--output_dir",
- str(output_dir),
- ],
+ command,
capture_output=True,
text=True,
)
@@ -53,11 +57,12 @@ def test_generate_header(self):
self.source_dir / "libc/newhdrgen/tests/expected_output/test_header.h"
)
output_file = self.output_dir / "test_small.h"
+ entry_points = {"func_b", "func_a", "func_c", "func_d"}
if not self.output_dir.exists():
self.output_dir.mkdir(parents=True)
- self.run_script(yaml_file, h_def_file, self.output_dir)
+ self.run_script(yaml_file, h_def_file, self.output_dir, entry_points)
self.compare_files(output_file, expected_output_file)
``````````
</details>
https://github.com/llvm/llvm-project/pull/99587
More information about the libc-commits
mailing list