[libc-commits] [libc] [libc] Added missing operator delete generated by gcc/clang (PR #67457)

Joseph Huber via libc-commits libc-commits at lists.llvm.org
Mon Jul 15 11:59:22 PDT 2024


jhuber6 wrote:

> > > > You likely need to add these to the integration test.cpp as well.
> > > 
> > > 
> > > integration tests build even without this patch
> > 
> > 
> > Probably because they don't hit the same code paths, but I feel like we should do it just in case.
> 
> Do yo mean
> 
> https://github.com/llvm/llvm-project/blob/148d90729e9fa132f170ba0627bcfb9ee90a0f38/libc/test/IntegrationTest/test.cpp#L4
> ?
> 
> I still prefer not to add code unless it's needed. Will you block the PR if I don't add the code there?

Honestly, these files are practically the same so we could probably just merge them into a single object library or something.

https://github.com/llvm/llvm-project/pull/67457


More information about the libc-commits mailing list