[libc-commits] [clang] [libc] [llvm] [OpenMP][libc] Remove special handling for OpenMP printf (PR #98940)

Joseph Huber via libc-commits libc-commits at lists.llvm.org
Mon Jul 15 11:18:10 PDT 2024


================
@@ -5892,8 +5892,6 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
         getTarget().getTriple().isAMDGCN() ||
         (getTarget().getTriple().isSPIRV() &&
          getTarget().getTriple().getVendor() == Triple::VendorType::AMD)) {
-      if (getLangOpts().OpenMPIsTargetDevice)
-        return EmitOpenMPDevicePrintfCallExpr(E);
----------------
jhuber6 wrote:

Not in this patch. It's still used for `NVPTX` because CUDA doesn't know it can do varargs yet. We could replace that with the same code I put in `LibC.h` here in one of the CUDA headers if we wanted to. OpenCL and HIP also still use the ROCm Device Libs for this.

https://github.com/llvm/llvm-project/pull/98940


More information about the libc-commits mailing list