[libc-commits] [libc] [libc][math] implement `signbit` and math macro unit tests (PR #97791)
Petr Hosek via libc-commits
libc-commits at lists.llvm.org
Sat Jul 13 20:09:35 PDT 2024
petrhosek wrote:
I don't think the `isnan*` tests should live in `test/include`, they should live in `test/sec/math` to mirror implementation in `src/math` just like we did for all other math functions. The same also applies `isinf*` to `isfinite*`. Right now the tests don't match the implementation because `isinfl`, `isinff`, `isfinitel` and `isfinitef` don't exist at all.
I think this change should have really just added tests for `signbit` just like the commit message says and `isinf*` and `isfinite*` in should have been covered in separate changes correctly.
https://github.com/llvm/llvm-project/pull/97791
More information about the libc-commits
mailing list