[libc-commits] [libc] [libc] Mark internal __llvm_libc_errno as noexcept (PR #98760)

Sat Jul 13 11:31:40 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `libc-x86_64-debian` running on `libc-x86_64-debian` while building `libc` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/43/builds/2048

Here is the relevant piece of the build log for the reference:
```
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py ...' (failure)
...
[357/363] Building CXX object projects/libc/src/unistd/linux/CMakeFiles/libc.src.unistd.linux.getcwd.dir/getcwd.cpp.o
[358/363] Building CXX object projects/libc/src/stdlib/CMakeFiles/libc.src.stdlib.strfromf.dir/strfromf.cpp.o
[359/363] Building CXX object projects/libc/src/stdio/scanf_core/CMakeFiles/libc.src.stdio.scanf_core.converter.dir/float_converter.cpp.o
[360/363] Building CXX object projects/libc/src/stdlib/CMakeFiles/libc.src.stdlib.strfromd.dir/strfromd.cpp.o
[361/363] Building CXX object projects/libc/src/stdio/printf_core/CMakeFiles/libc.src.stdio.printf_core.converter.dir/converter.cpp.o
[362/363] Building CXX object projects/libc/src/stdlib/CMakeFiles/libc.src.stdlib.strfroml.dir/strfroml.cpp.o
[363/363] Linking CXX static library projects/libc/lib/libllvmlibc.a
@@@BUILD_STEP libc-unit-tests@@@
Running: ninja libc-unit-tests
[1/2631] Building CXX object projects/libc/src/errno/CMakeFiles/libc.src.errno.errno.__internal__.dir/libc_errno.cpp.o
FAILED: projects/libc/src/errno/CMakeFiles/libc.src.errno.errno.__internal__.dir/libc_errno.cpp.o 
/usr/bin/clang++ -DLIBC_NAMESPACE=__llvm_libc_19_0_0_git -I/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian/libc-x86_64-debian/build/projects/libc/src/errno -I/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian/libc-x86_64-debian/llvm-project/libc/src/errno -I/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian/libc-x86_64-debian/llvm-project/libc -isystem /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian/libc-x86_64-debian/build/projects/libc/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -fpie -fno-builtin -fno-exceptions -fno-lax-vector-conversions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wall -Wextra -Werror -Wconversion -Wno-sign-conversion -Wimplicit-fallthrough -Wwrite-strings -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wstrict-prototypes -Wthread-safety -Wglobal-constructors -std=c++17 -MD -MT projects/libc/src/errno/CMakeFiles/libc.src.errno.errno.__internal__.dir/libc_errno.cpp.o -MF projects/libc/src/errno/CMakeFiles/libc.src.errno.errno.__internal__.dir/libc_errno.cpp.o.d -o projects/libc/src/errno/CMakeFiles/libc.src.errno.errno.__internal__.dir/libc_errno.cpp.o -c /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian/libc-x86_64-debian/llvm-project/libc/src/errno/libc_errno.cpp
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian/libc-x86_64-debian/llvm-project/libc/src/errno/libc_errno.cpp:60:17: error: '__llvm_libc_errno' is missing exception specification 'noexcept'
extern "C" int *__llvm_libc_errno() { return &thread_errno; }
                ^
                                    noexcept
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian/libc-x86_64-debian/llvm-project/libc/src/errno/libc_errno.h:36:17: note: previous declaration is here
extern "C" int *__llvm_libc_errno() noexcept;
                ^
1 error generated.
[2/2631] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.feraiseexcept.__internal__.dir/feraiseexcept.cpp.o
[3/2631] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fesetround.__internal__.dir/fesetround.cpp.o
[4/2631] Building CXX object projects/libc/src/inttypes/CMakeFiles/libc.src.inttypes.strtoumax.__internal__.dir/strtoumax.cpp.o
[5/2631] Building CXX object projects/libc/src/inttypes/CMakeFiles/libc.src.inttypes.strtoimax.__internal__.dir/strtoimax.cpp.o
[6/2631] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fegetenv.__internal__.dir/fegetenv.cpp.o
[7/2631] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fegetround.__internal__.dir/fegetround.cpp.o
[8/2631] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fetestexcept.__internal__.dir/fetestexcept.cpp.o
[9/2631] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.feclearexcept.__internal__.dir/feclearexcept.cpp.o
[10/2631] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fegetexceptflag.__internal__.dir/fegetexceptflag.cpp.o
[11/2631] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fetestexceptflag.__internal__.dir/fetestexceptflag.cpp.o
[12/2631] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.feupdateenv.__internal__.dir/feupdateenv.cpp.o
[13/2631] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fesetexceptflag.__internal__.dir/fesetexceptflag.cpp.o
[14/2631] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fesetexcept.__internal__.dir/fesetexcept.cpp.o
[15/2631] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fedisableexcept.__internal__.dir/fedisableexcept.cpp.o
[16/2631] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fesetenv.__internal__.dir/fesetenv.cpp.o
[17/2631] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.feholdexcept.__internal__.dir/feholdexcept.cpp.o
[18/2631] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fegetexcept.__internal__.dir/fegetexcept.cpp.o
[19/2631] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.feenableexcept.__internal__.dir/feenableexcept.cpp.o
[20/2631] Building CXX object projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.canonicalizel.__internal__.dir/canonicalizel.cpp.o
[21/2631] Building CXX object projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.ceil.__internal__.dir/ceil.cpp.o
[22/2631] Building CXX object projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.ceilf.__internal__.dir/ceilf.cpp.o
[23/2631] Building CXX object projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.canonicalizef.__internal__.dir/canonicalizef.cpp.o
[24/2631] Building CXX object projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.canonicalize.__internal__.dir/canonicalize.cpp.o
[25/2631] Building CXX object projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.ceilf128.__internal__.dir/ceilf128.cpp.o
[26/2631] Building CXX object projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.canonicalizef128.__internal__.dir/canonicalizef128.cpp.o
[27/2631] Building CXX object projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.ceill.__internal__.dir/ceill.cpp.o
[28/2631] Building CXX object projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.cos.__NO_FMA_OPT.__NO_ROUND_OPT.dir/cos.cpp.o
[29/2631] Building CXX object projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.cos.__NO_FMA_OPT.__NO_ROUND_OPT.__internal__.dir/cos.cpp.o
[30/2631] Building CXX object projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.cos.__internal__.dir/cos.cpp.o

```

https://github.com/llvm/llvm-project/pull/98760